[Mimedefang] Allowing trailing commas in filenames

[Clayton, Nik [IT]]

[ Currently using MimeDefang 2.16 ]

How do people feel about allowing trailing commas in filenames?

We recently had some attachments stripped from messages when they
shouldn't have been.  The third party was generating attachments with
filenames that took the form:

    first.last at citigroup.com,,file.txt

Ignoring for the moment that that's a fairly broken format for naming
files (but not, I think, dangerous), MimeDefang was stripping it, because 
the

    ... .com, ...

bit of the filename matched this line:

    $re = '(\{)|(\})|(\.' . $bad_exts . ')\.*([^-A-Za-z0-9_.]|$)';

in mimedefang-filter:filter_bad_filename().

I think a comma can safely be added there, so that it becomes:

    $re = '(\{)|(\})|(\.' . $bad_exts . ')\.*([^-A-Za-z0-9_.,]|$)';

Thoughts?

N
-- 
1        1         2         3         4         5         6         7    7
         0         0         0         0         0         0         0    5
  -- The 75 column-ometer

Global Messaging      120 Cheapside, x83331