[Mimedefang] return values

[Dianne Skoll]

Hi,

> Shouldn't filter() and filter_multipart() simply use "return;" (with
> no return value)?  If not, please help me understand.

The return value of filter and filter_multipart is ignored.
I sometimes write:

  return action_accept();

as shorthand for:

   action_accept();
   return;

> Issue 2:  bounce or discard, which is it?

Yeah, that makes no sense. :)

> In the "suggested-minimum-filter." filter function, there is this:

>     # Block message/partial parts
>     if (lc($type) eq "message/partial") {
>         md_graphdefang_log('message/partial');
>         action_bounce("MIME type message/partial not accepted here");
>         return action_discard();
>     }

Replace return action_discard(); with return;

I will fix the filter.

Regards,

Dianne.