[Mimedefang] $fname in filter() is an array reference

Dave O'Neill dmo at roaringpenguin.com
Tue Mar 2 09:26:40 EST 2010


On Mon, Mar 01, 2010 at 06:05:38PM -0500, Matt Garretson wrote:
> My understanding is that the parens cause takeStabAtFilename() to 
> be called in a list context, which in turn for is causing MIME-tools' 
> decode_mimewords() to return an array rather than a scalar. The 
> attached trivial patch to mimedefang.pl.in ditches the parens, 
> causing $fname to be a scalar string as documented within MIMEdefang.

The real problem is that decode_mimewords() should have been forced to 
scalar context.  

> Now, the man page for MIME::Words says that forcing decode_mimewords()
> to return a scalar is "probably not what you want", but it certainly
> is easier to deal with, and it matches the MD's comments and docs.

It's also what previous versions (without the bug) did, so we'll 
preserve that behaviour for now.

See attached for the new patch.

Cheers,
Dave
-- 
Dave O'Neill <dmo at roaringpenguin.com>    Roaring Penguin Software Inc.
+1 (613) 231-6599                        http://www.roaringpenguin.com/
For CanIt technical support, please mail: support at roaringpenguin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Bugfix-Ensure-decode_mimewords-is-called-in-scala.patch
Type: text/x-diff
Size: 957 bytes
Desc: not available
URL: <https://lists.mimedefang.org/pipermail/mimedefang_lists.mimedefang.org/attachments/20100302/b52ed64d/attachment.bin>


More information about the MIMEDefang mailing list