[Mimedefang] $Features not showing Net::DNS

Erin Fortenberry kahn.no at gmail.com
Fri Apr 10 21:52:08 EDT 2009


> From: mimedefang-bounces at lists.roaringpenguin.com [mailto:mimedefang-
> 
> "David F. Skoll" <dfs at roaringpenguin.com> wrote:
> 
> > Andrzej Adam Filip wrote:
> >
> >> Anyway SpamAssassin avoids "one socket per one DNS query" it its DNS
> >> lookups perl package
> >
> > This is true.  On the other hand, it replaces a 75-line function with
> > 1473 lines of perl.  I wonder which has more overhead?
> >
> > You are right about one thing:  If you are using SA anyway, then you
> > might as well try to reuse its DNS code.  But holding up SA code as
> an
> > example of "performance-optimized perl" is pretty ridiculous. :-)  SA
> > is a huge, bloated, infected-with-not-invented-here-syndrome pig.
> 
> It's worst sin (for me) is it's coding methodology almost like
> "no part of this code will be usable anywhere else" :-)
> 
> BTW Are you aware about any efforts to "locally join" DNSBL/DNSWL lists
> available in full version via rsync? [to get "single lookup required"
> result]

</threadjack>

Ok, well, so now that we are done with that....

I have found the following lines to be of no problem in mimedefang.pl (lines
105-108);

	if (!defined($Features{"Net::DNS"})) {
	    (eval 'use Net::DNS; $Features{"Net::DNS"} = 1;')
		or $Features{"Net::DNS"} = 0;
	}

It loads and sets $Features{"Net::DNS"} to 1.


But, the following lines (1535) are a problem;

    unless ($Features{"Net::DNS"}) {

This is true when it needs to be false. If you change it to;

    unless (!$Features{"Net::DNS"}) {

Then things are good again. So, this looks like a bug. Where do I post a
bug?


-Erin






More information about the MIMEDefang mailing list