md_syslog (was Re: [Mimedefang] Woes following an OS upgrade)

David F. Skoll dfs at roaringpenguin.com
Tue Nov 7 14:33:51 EST 2006


Philip Prindeville wrote:

> Oh...  and in digging around, I saw:
> sub md_syslog ($$) {
>     my($facility, $msg) = @_;

[...]

> Hmm...  Klunky.  What about:

> sub md_syslog ($$;@) {
>     my($facility, $fmt, @args) = @_;

Except that now all callers of md_syslog have to change.  That's no good.
Every single caller of md_syslog would have to ensure that its first argument
didn't contain any printf-sequences, and most calls would devolve to:

	md_syslog($facility, "%s", $msg);

which is why I did it the first way originally.

Regards,

David.



More information about the MIMEDefang mailing list