[Mimedefang] ACCEPT_AND_NO_MORE_FILTERING leaves behind workingfiles in /var/spool/MIMEdefang

[Mack]

Nicely Spotted, I did wonder where those orphan files were coming from, but
they seemed so infrequent (i never investigated it any further!)

Guess i'll have to patch the only server i have that uses the AANMF return
val

Cheers

Mack



-----Original Message-----
From: mimedefang-bounces at lists.roaringpenguin.com
[mailto:mimedefang-bounces at lists.roaringpenguin.com]On Behalf Of David
F. Skoll
Sent: 17 November 2005 18:10
To: mimedefang at lists.roaringpenguin.com
Subject: Re: [Mimedefang] ACCEPT_AND_NO_MORE_FILTERING leaves behind
workingfiles in /var/spool/MIMEdefang


Ken Menzel wrote:

> I am trying to implement a recipient filter.  It seems to mostly work as
> intended except when I use ACCEPT_AND_NO_MORE_FILTERING as the return
> option mimedefang slowly fills /var/spool/MIMEdefang directory with left
> over COMMAND and HEADER files in the working directories.

Congratulations!  You've found a bug in mimedefang.c!

The patch below should fix it.  Sorry about that!

Regards,

David.

--- mimedefang-2.54/mimedefang.c	2005-10-14 12:33:27.000000000 -0400
+++ mimedefang-2.55/mimedefang.c	2005-11-17 13:07:13.000000000 -0500
@@ -16,7 +16,7 @@
 ***********************************************************************/

 static char const RCSID[] =
-"$Id: mimedefang.c,v 1.229 2005/10/14 16:33:27 dfs Exp $";
+"$Id: mimedefang.c,v 1.230 2005/11/17 18:07:13 dfs Exp $";

 /* Define this to work around an M$ Outlook bug! */
 /* #define CONVERT_EMBEDDED_CRS_IN_HEADERS 1 */
@@ -882,8 +882,8 @@
 	}
 	if (n == 2) {
 	    set_dsn(ctx, ans, 2);
-
-	    retcode = SMFIS_ACCEPT;
+	    cleanup(ctx);
+	    return SMFIS_ACCEPT;
 	}
 	if (n == 3) {
 	    set_dsn(ctx, ans, 2);
_______________________________________________
Visit http://www.mimedefang.org and http://www.roaringpenguin.com
MIMEDefang mailing list
MIMEDefang at lists.roaringpenguin.com
http://lists.roaringpenguin.com/mailman/listinfo/mimedefang

This Email Has Been Anti-Virus Scanned