[Mimedefang] suggested-minimum-filter-for-windows-clients,v 1.43

[Steffen Kaiser]

On Tue, 27 Aug 2002, Marco Berizzi wrote:

Hi,

> From the suggested-minimum-filter:
>
> # eml is bad if it's not multipart
>     if (re_match($entity, '\.eml')) {
>         return action_quarantine($entity, "bla bla bla...
>
> Shoudn't be: if (re_match($entity, '^\.eml$'))  ?

re_match() is executing:
return 1 if $guess =~ /$regexp/i;
-->   if <filename> =~ /\.eml/i;

I'd suggest using (dollar sign only):
if (re_match($entity, '\.eml$'))

so the '.eml' extension must be the last portion of the filename and
filenames like:

bar.eml.foo.mpeg
-or-
bar.emlist.txt

are not matched, but I don't know how this attachment is to work at all.

The caret would be wrong, as this would mean that the filename must begin
with '.eml'.

Bye,

-- 

Steffen Kaiser